Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Add E2E tests #388

Merged
merged 7 commits into from
Sep 18, 2023
Merged

[1.x] Add E2E tests #388

merged 7 commits into from
Sep 18, 2023

Conversation

andrii-i
Copy link
Collaborator

Backports #350 to 1.x

* add basic e2e testing setup

* adjust execute test step name

* test sidebar chat icon, add testing class

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add sidebar snapshot

* test chat sidepanel, extend helper class

* adjust welcome message test, add snapshot

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* adjust naming

* removeempty line

* move ui-tests to packages/jupyter-ai/

* update e2e ci workflow for ui-tests folder move

* update ui-tests folder location for yarn.lock hash

* run lint locally

* Add "Update Playwright Snapshots" CI workflow

* change if clause

* specify npm client

* remove report and artifact specifiers

* Update README.md to have correct commands and folders

* update e2e/integration test README

* Add Integration / E2E testing section to the docs

* update wording of docs on snapshots

* Ignore all non-linux snapshots

* Update packages/jupyter-ai/ui-tests/README.md

Co-authored-by: Piyush Jain <[email protected]>

* remove cd command that would return users back to root

* remove cd ../../../

* Remove repeating setup instructions

* Add suggestion to generate snapshots before the 1st run

* remove unnecessary link anchor

* remove rudimentary jlpm build

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Piyush Jain <[email protected]>
@andrii-i andrii-i added enhancement New feature or request maintenance Change related to maintenance of the repository testing Quality assurance tests project:ui In-editor dialog/popup UI, improve selction UI labels Sep 13, 2023
@andrii-i andrii-i marked this pull request as draft September 13, 2023 06:47
@andrii-i
Copy link
Collaborator Author

Kicking CI

@andrii-i andrii-i closed this Sep 18, 2023
@andrii-i andrii-i reopened this Sep 18, 2023
@andrii-i andrii-i marked this pull request as ready for review September 18, 2023 17:40
@andrii-i andrii-i merged commit 491490a into jupyterlab:1.x Sep 18, 2023
@andrii-i andrii-i deleted the 1.x-ui-tests branch September 18, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance Change related to maintenance of the repository project:ui In-editor dialog/popup UI, improve selction UI testing Quality assurance tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant